Refactor mailers #1105
Open
Refactor mailers #1105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creates the Claims::ApplicationMailer and Placements::Application which inherit from ApplicationMailer and moves service specific methods into their respectively namespaced application mailer.
Creates the Placements::SupportUserMailer and Claims::SupportUserMailer, also removes the original SupportUserMailer. This is because the service mailers are going to diverge in the near future, so translation files and logic has been split.
Creates the Placements::UserMailer and Claims::UserMailer, also removes the original UserMailer. This is because the service mailers are going to diverge in the near future, so translation files and logic has been split.
Kizr
force-pushed
the
ba/refactor-mailers
branch
from
c730b5b
to
08cd617
Compare
Deployments
|
Kizr
commented
Oct 11, 2024
app/services/application_service.rb
Outdated
Comment on lines
11
to
30
|
|
||
| private | ||
|
|
||
| def user_mailer_class(service) | ||
| case service | ||
| when :placements | ||
| Placements::UserMailer | ||
| when :claims | ||
| Claims::UserMailer | ||
| end | ||
| end | ||
|
|
||
| def support_user_mailer_class(service) | ||
| case service | ||
| when :placements | ||
| Placements::SupportUserMailer | ||
| when :claims | ||
| Claims::SupportUserMailer | ||
| end | ||
| end |
There was a problem hiding this comment.
Where do we think these should live? They're only relevant to services and each method is used in two services. Maybe these could live in the application mailer instead?
Removes service param from mailer calls and replaces it with the appropriate mailer class. Adds a method to return the correct mailer class in service objects and refactors tests to accommodate this change.
Kizr
force-pushed
the
ba/refactor-mailers
branch
from
08cd617
to
7bd2cdb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We need some more flexibility in our mailers so different services can send different emails to different types of users.
Changes proposed in this pull request
Claims::ApplicationMailerandPlacements::ApplicationMailerwhich split out the service dependent logic.Claims::UserMailerandPlacements::UserMailerwhich inherit from thier service specific application mailerUserMailerClaims::SupportUserMailerandPlacements::SupportUserMailerwhich inherit from thier service specific application mailerSupportUserMaileruser_mailer_classandsupport_user_mailer_classmethods to find the correct mailer to use for the current serviceGuidance to review
On the claims and placements services:
Link to Trello card
Refactor email notifications to be service specific