Support claims index page filters #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CatalinVoineag
force-pushed
the
cv/support-claim-index
branch
2 times, most recently
from
17edfe8
to
9a9c825
Compare
CatalinVoineag
force-pushed
the
cv/support-claim-index
branch
5 times, most recently
from
467c2e9
to
57ffe46
Compare
CatalinVoineag
added
the
deploy
|
Review app track and pay deployed to https://track-and-pay-447.test.teacherservices.cloud was deleted |
Nitemaeric
reviewed
Apr 12, 2024
app/javascript/controllers/claims_support_filter_search_controller.js
Outdated
Show resolved
Hide resolved
|
This is also a pretty complex change. It would help reviewers if this PR was broken down into step-by-step commits. |
gms-gs
reviewed
Apr 12, 2024
CatalinVoineag
force-pushed
the
cv/support-claim-index
branch
from
57ffe46
to
fe1286b
Compare
CatalinVoineag
force-pushed
the
cv/support-claim-index
branch
from
fe1286b
to
46fd3ed
Compare
CatalinVoineag
force-pushed
the
cv/support-claim-index
branch
from
46fd3ed
to
9f93aed
Compare
Nitemaeric
reviewed
Apr 12, 2024
We need to allow our support users to filter the claims. Two filters, School and Provider filters have 2 search fields where you can search by school name or provider to get the filter you want. This is done by javascript in a stimulus controller. The other 2 filters, Submitted after and Submitted before filters are date filters and use the govuk_date_field form helper. You cannot set the value of this helper as it's sending 3 params not just 1. So to persist the value of these filters we need a form object. Claims::Support::Claims::FilterForm is a form object that is meant to just house the params and all the logic that these filter need. All the params of the filters are in the url.
CatalinVoineag
force-pushed
the
cv/support-claim-index
branch
from
9f93aed
to
6de4acb
Compare
Nitemaeric
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We need to allow our support users to filter the claims.
Two filters,
SchoolandProviderfilters have 2 search fields whereyou can search by school name or provider to get the filter you want.
This is done by javascript in a stimulus controller.
The other 2 filters,
Submitted afterandSubmitted beforefilters aredate filters and use the
govuk_date_fieldform helper. You cannot setthe value of this helper as it's sending 3 params not just 1. So to
persist the value of these filters we need a form object.
Claims::Support::Claims::FilterFormis a form object that is meant tojust house the params and all the logic that these filters need.
All the params of the filters are in the url.
Changes proposed in this pull request
Claims::Support::Claims::FilterFormStimulus controller
Styling changes
Guidance to review
Sign in as colin
Go to support claims index
Filter claims by all the filters
Use the search too
Screenshots
Peek.2024-04-11.16-10.mp4