Update Support Claims page #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployments
|
Use `name` for the search field name, as standard form field helpers use. Use `value` for the search field input value, as standard form field helpers use. Also default to `params[name]`. The `label` argument now accepts a hash with `text` and `size`. This is to allow the customisation of the label font size.
This defaults money formatting to use commas for thousands separators with the default `en` locale.
Compose upon the govuk tag component.
Nitemaeric
force-pushed
the
dd/style-support-claims-list
branch
from
503f887
to
43f89a0
Compare
Nitemaeric
force-pushed
the
dd/style-support-claims-list
branch
from
43f89a0
to
603bac9
Compare
| @@ -0,0 +1,9 @@ | |||
| class Claim::CardComponent < ApplicationComponent | |||
There was a problem hiding this comment.
Does this need a spec and a preview?
There was a problem hiding this comment.
Ah yes, I'll add that. Nice catch.
There was a problem hiding this comment.
Added a relatively basic spec for the component, along with a preview.
Nitemaeric
force-pushed
the
dd/style-support-claims-list
branch
from
603bac9
to
45218c7
Compare
- Add Claim::CardComponent - Add pagination count to Support Claims page heading and title - Add search bar to filter claims by reference number
Nitemaeric
force-pushed
the
dd/style-support-claims-list
branch
from
45218c7
to
264517a
Compare
CatalinVoineag
approved these changes
Apr 8, 2024
JamieCleare2525
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We want to allow Support Users to see the list of all submitted Claims.
Changes proposed in this pull request
shared/_search_form.html.erbto become a generic UI component. (Could possibly be further refactored into a View Component)Money.default_backendto:i18n.Claims::StatusTagComponentto usegovuk_taginstead ofcontent_tag(:p).Claim::CardComponentand use it on the support claims page.shared/_search_formpartial to render the search bar for claims with a smaller label.Guidance to review
By updating the
search_formpartial, I've had to make some adjustments to the School Placements code. cc: @DFE-Digital/school-placementsRubyMoney provides 2 modern default localisation strategies,
currencyandi18n. I've opted to usingi18nsince our users should all be British, but it shouldn't make a difference in our use-case.currencyuses the currency's defaults to format a money value.i18nuses the locale to determine formatting.Use the
govuk_tagcomponent in theClaim::StatusTagComponent. As the fundamental UI component is based on the govuk tag, it should keep things more consistent.Check if the CSS for the
Claims::CardComponentcould be cleaner?Screenshots