Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add feedback link to placements service #463

Merged
merged 4 commits into from
Apr 11, 2024
Merged

Add feedback link to placements service #463

merged 4 commits into from
Apr 11, 2024

Conversation

JamieCleare2525
Copy link
Contributor

Context

Changes proposed in this pull request

Guidance to review

Link to Trello card

https://trello.com/c/YLnTOWcO/233-add-feedback-link-to-service-footer

@JamieCleare2525 JamieCleare2525 self-assigned this Apr 10, 2024
@JamieCleare2525 JamieCleare2525 requested review from a team as code owners April 10, 2024 13:02
Nitemaeric
Nitemaeric reviewed Apr 10, 2024
View reviewed changes
Copy link
Contributor

@Nitemaeric Nitemaeric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might also want to remove the route definition that created the placements_feedback_url helper.

@JamieCleare2525 JamieCleare2525 merged commit 2e46308 into main Apr 11, 2024
7 checks passed
@JamieCleare2525 JamieCleare2525 deleted the jc/add_feedback_link branch April 11, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nitemaeric Nitemaeric Nitemaeric approved these changes

@ollietreend ollietreend ollietreend approved these changes

@gms-gs gms-gs gms-gs approved these changes

Assignees

@JamieCleare2525 JamieCleare2525

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JamieCleare2525 @Nitemaeric @ollietreend @gms-gs