Consolidate options form components #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamieCleare2525
added
the
deploy
JamieCleare2525
changed the title
|
Review app track and pay deployed to https://track-and-pay-468.test.teacherservices.cloud was deleted |
Kizr
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
SchoolOptionsFormComponentandProviderOptionsFormComponentshared almost identical code. These have been replaced with a more reusableOptionsFormComponentChanges proposed in this pull request
OptionsFormComponentSchoolOptionsFormComponentwithOptionsFormComponentProviderOptionsFormComponentwithOptionsFormComponentGuidance to review
(as Support User Colin)
Claims
Placements
Previews available
http://placements.localhost:3000/rails/view_components
http://placements.localhost:3000/rails/view_components/options_form_component/less_than_15_providers
http://placements.localhost:3000/rails/view_components/options_form_component/less_than_15_schools
http://placements.localhost:3000/rails/view_components/options_form_component/more_than_15_providers
http://placements.localhost:3000/rails/view_components/options_form_component/more_than_15_schools
http://claims.localhost:3000/rails/view_components
http://claims.localhost:3000/rails/view_components/options_form_component/less_than_15_providers
http://claims.localhost:3000/rails/view_components/options_form_component/less_than_15_schools
http://claims.localhost:3000/rails/view_components/options_form_component/more_than_15_providers
http://claims.localhost:3000/rails/view_components/options_form_component/more_than_15_schools
Link to Trello card
https://trello.com/c/4Olltsra/234-consolidate-schooloptionsformcomponent-and-provideroptionsformcomponent-into-1-reusable-component
Screenshots
More than 15 schools
More than 15 providers
Less than 15 schools
Less that 15 providers
