Refactor dsi redirect in omniauth #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need the dsi redirect to be more flexible, to allow more hosts to user DFE sign in so this commit just gets the base url from the request i.e. http://host:port and we can append `auth/dfe/callback` to it.
gms-gs
approved these changes
Apr 12, 2024
ollietreend
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We need the dsi redirect to be more flexible, to allow more hosts to user DFE sign in so this commit just gets the base url from the request i.e. http://host:port and we can append
auth/dfe/callbackto it.Changes proposed in this pull request
Omniauth dsi redirect URL
HostingEnvironment methods cleanup
Guidance to review
Use DFE sign-in on your local
It should work as normal