Calculate total mentor training hours for a mentor for a given provider #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gms-gs
changed the title
CatalinVoineag
approved these changes
Apr 12, 2024
| end | ||
|
|
||
| def call | ||
| mentor.mentor_trainings.where(provider:).sum(:hours_completed) |
There was a problem hiding this comment.
I wonder if this service should also calculate hours per academic year. But for now this is enough I think
There was a problem hiding this comment.
Yeah, it should. But we'll ignore the concept of academic years for now. We'll be addressing academic years after the private beta.
Nitemaeric
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We should not allow a mentor to submit over 20 hours of training hours. Currently a mentor can submit 20 hours per claim meaning they can submit over 20 hours in total.
Changes proposed in this pull request
This change creates a service
Claims::CalculateTotalMentorTrainingHoursForProviderwhich returns the total number of mentor training hours for a mentor. This logic will be used in the scenario where a mentor already has submitted 20 hours on a claim, and potentially attempts to submit another 20 hours on another claim for the same provider.NOTE: They can submit 20 hours in total per provider
Guidance to review
Link to Trello card
https://trello.com/c/B637194w/372-set-up-logic-to-only-allow-a-mentor-to-claim-up-to-20-hours-per-provider