Allow DSI user to actually sign out #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the sign out link didn't actually comunicated with DSI to log out the user. It would still keep them logged in, on their end. This commit will send a request to DSI to logout the user and redirect back to our own sign out path
CatalinVoineag
force-pushed
the
cv/sign-out-user
branch
from
fb2fa32
to
026aa93
Compare
Nitemaeric
reviewed
Apr 16, 2024
JamieCleare2525
approved these changes
Apr 16, 2024
Nitemaeric
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Previously, the sign out link didn't actually comunicated with DSI to
log out the user. It would still keep them logged in, on their end.
This commit will send a request to DSI to logout the user and redirect
back to our own sign out path
Changes proposed in this pull request
New logout URL in the app
The logout URL has changed in the DSI console, for both placements and claims
Guidance to review
Sign in with dfe sign in on local
Sign out
You should get the sign in form again
Screenshots
Current:
Peek.2024-04-15.16-12.mp4
Previously:
Peek.2024-04-15.16-14.mp4