[CPDLP-3586] NPQ Internal API - Implement DQT API calls in NPQ #1753
Conversation
|
Review app deployed to https://npq-registration-review-1753-web.test.teacherservices.cloud/ |
| @@ -0,0 +1,25 @@ | |||
| module Dqt | |||
| module V1 | |||
There was a problem hiding this comment.
The ticket mentions using v3 instead of v3, did something change/is this something different?
There was a problem hiding this comment.
we discussed this with the TRA team and unfortunately V3 is missing some features so we had to go back to V1 for now. Since this will all be deprecated soon they agreed for us to go with V1
There was a problem hiding this comment.
Ah yes, we had a meeting about this and found v3 doesn't include some things we need. We're sticking with v1 for migration, and likely replace all this in the future.
There was a problem hiding this comment.
should have refreshed first lol
| let(:response_hash) do | ||
| { | ||
| "trn": trn, | ||
| "ni_number": "AB123456D", |
There was a problem hiding this comment.
Is it worth stubbing out the whole response here or just the two fields we actually use? arguably its good to see an 'expected response', but it makes the test harder to understand IMO 🤔
There was a problem hiding this comment.
You're right, will remove unnecessary response values.
| end | ||
|
|
||
| before do | ||
| allow(Dqt::V1::Teacher).to receive(:validate_trn) |
There was a problem hiding this comment.
We could do the Teacher service stub in a single before block at the top and then just a let(:body) {} for each context
mooktakim
force-pushed
the
3586-npq-internal-api-implement-dqt-api-calls-in-npq
branch
from
3453d01
to
b72dd56
Compare
Prepod and Production API keys for DQT added to npq-reg app environments. 👍 |
There was a problem hiding this comment.
Looking good but I think we might need to catchup on matches: ECF has a bit more logic around confirming if matches are correct https://github.com/DFE-Digital/early-careers-framework/blob/main/app/services/dqt_record_check.rb#L45 I think we might need to port that over?
mooktakim
force-pushed
the
3586-npq-internal-api-implement-dqt-api-calls-in-npq
branch
from
b72dd56
to
ccf2318
Compare
mooktakim
force-pushed
the
3586-npq-internal-api-implement-dqt-api-calls-in-npq
branch
from
ccf2318
to
8df2bad
Compare
mooktakim
force-pushed
the
3586-npq-internal-api-implement-dqt-api-calls-in-npq
branch
from
8df2bad
to
1c08d62
Compare
|
Context
Ticket: https://dfedigital.atlassian.net.mcas.ms/browse/CPDLP-3586
Changes proposed in this pull request
Dqt::V1::TeacherclientDqt::RecordCheckParticipantValidatorto use DQT whenecf_api_disabledis on.