394: Add low-fi view ECT record #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edujackedu
force-pushed
the
394-ect-page
branch
from
f7fef0e
to
57dfe3c
Compare
edujackedu
commented
Oct 7, 2024
| row.with_key(text: "Induction status") | ||
|
|
||
| # FIXME: This is a placeholder. The actual status should be displayed here. | ||
| row.with_value(text: govuk_tag(text: "placeholder", colour: %w[grey green red purple orange yellow].sample)) |
There was a problem hiding this comment.
should we use the status coming from the TRS API or are we going to have our own status values? @peteryates
There was a problem hiding this comment.
I think this is where we'll show the overall induction status, which we will hold the 'truth' of in our database and push updates to TRS as and when they happen. We don't know what the possible values are yet though.
There was a problem hiding this comment.
Let's keep the placeholder for now then
peteryates
reviewed
Oct 8, 2024
edujackedu
force-pushed
the
394-ect-page
branch
from
57dfe3c
to
fc696e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update ECT record view to match low-fi design:
Design:
Result: