Fix login screen when personas is disabled #447
+46
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The personas_path is now missing when personas are disabled so we want to avoid calling the helper. Moving the logic to a helper tidies the logic up and makes it easier to test.
This is a subtle change but it means that the route will always show up in `rails routes` regardless of the check, but it'll still block people from visiting it unless the constraint is met
peteryates
added
the
Deploy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The personas_path is now unreachable when
ENABLE_PERSONASis false, so we want to avoid calling the helper elsewhere. Moving the logic to a helper tidies the logic up and makes it easier to test.