Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

431: Update teacher not found message #458

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

edujackedu
Copy link
Contributor

@edujackedu edujackedu commented Oct 11, 2024

Update the error message to tell the users what to do if teacher is not found

@edujackedu edujackedu force-pushed the 431-update-not-found-error-message branch from 23c9eee to db99ad5 Compare October 11, 2024 15:51
@edujackedu edujackedu marked this pull request as ready for review October 11, 2024 15:51
Comment on lines +18 to +21
raise(
TRS::Errors::TeacherNotFound,
"Teacher with TRN #{trn} not found. Please liaise with the ECT to confirm their DOB and TRN or contact support"
)
Copy link
Member

@peteryates peteryates Oct 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This error is kind of shared between the TRN and the DOB, I think the error should include both field name. The link on the error summary probably should still go to the TRN field though so I think it should remain on :trn rather than :base.

Also the tone of the language here isn't quite right in my opinion, words like 'Please' are avoided.

Maybe:

Suggested change
raise(
TRS::Errors::TeacherNotFound,
"Teacher with TRN #{trn} not found. Please liaise with the ECT to confirm their DOB and TRN or contact support"
)
raise(
TRS::Errors::TeacherNotFound,
"No teacher with the provided teacher reference number and date of birth was found"
)

Additionally it might be a good idea to separate the raised error text from the error text we add to the object, as it would be useful to get the incorrect TRN/DOB in there (I suspect it's not PII if it's invalid?) In that case the above text can go in the rescue in the controller.

I think the guidance on contacting support if the details entered look right but don't match anything should either go in a hint or in a paragraph above between the page heading and the TRN field. We can use the design in #430 as a starting off point, but the hint text doesn't work for us because the AB (probably) won't have the payslip or reg documents from GTCE.

Find your ECT by entering their teacher reference number (TRN) and date of birth. If you can't find them contact support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants