Fix versioning issue #3242
Merged
Fix versioning issue #3242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review app deployed to https://get-school-experience-review-pr-3242.test.teacherservices.cloud |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello card
Context
In trying to set up this app for the first time, I ran into an issue where my tool version manager (mise) picked up the outdated
.nvimrcand tried to install node v8.11.2 where the README calls for v18, and running yarn calls for anything >= v10.The
.ruby-versionfile also specified 3.1.4, where as the.tool-versionsfile specified 3.1.0Changes proposed in this pull request
.nvmrcfile.tool-versionsfile.tool-versionsfileThis should make things a lot easier for others to set up for the first time, especially if they're using asdf or mise.
Guidance to review