Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No js degree inputbox #3246

Merged
merged 5 commits into from
Jul 30, 2024
Merged

No js degree inputbox #3246

merged 5 commits into from
Jul 30, 2024

Conversation

martyn-w
Copy link
Contributor

Trello card

No-javascript free text box for degree subject

Context

If a browser has javascript disabled, display a textbox to capture the degree subject, rather than a very long select list

Changes proposed in this pull request

Guidance to review

Test with JS enabled and disabled

@github-actions github-actions bot added ruby Pull requests that update Ruby code Test Config Style labels Jul 29, 2024
Copy link

Copy link
Contributor

@spencerldixon spencerldixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@martyn-w martyn-w merged commit 612b7be into master Jul 30, 2024
15 checks passed
@martyn-w martyn-w deleted the no-js-degree-inputbox branch July 30, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Config Review ruby Pull requests that update Ruby code Style Test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants