-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A11y change focus order on mobile devices #6879
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review app https://teaching-vacancies-review-pr-6879.test.teacherservices.cloud was successfully deleted |
scruti
approved these changes
May 29, 2024
ddippolito
force-pushed
the
a11y-change-focus-order-on-mobile-devices
branch
from
June 3, 2024 08:54
eded2b6
to
3829d2f
Compare
On iOS voiceover, the elements on the page are being skippedaa on the profiles question pages. The button appears to be the first element selected on load. This fixes the issue by forcing the focus of the mobile page on the first element of the page itself which is the skip to next section button
ddippolito
force-pushed
the
a11y-change-focus-order-on-mobile-devices
branch
from
June 5, 2024 08:44
3829d2f
to
d5d6a9e
Compare
ddippolito
force-pushed
the
a11y-change-focus-order-on-mobile-devices
branch
from
June 5, 2024 13:47
324d81e
to
43ba277
Compare
ddippolito
force-pushed
the
a11y-change-focus-order-on-mobile-devices
branch
from
June 5, 2024 14:04
782ac33
to
d9187e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello card URL
https://trello.com/c/4GiEypOW/979-a11y-243-focus-order-tab-order-is-not-logical-on-mobile-devices-giving-elements-unique-ids-on-personal-details-section-of-profil
Changes in this PR:
Add autofocus on Skip Section for mobile users.
On iOS voiceover, the elements on the page are being skipped on the profiles question pages. The button appears to be the first element selected on load. This fixes the issue by forcing the focus of the mobile page on the first element of the page itself which is the skip to next section button
Screenshots of UI changes: