Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rubocop-rspec from 2.31.0 to 3.0.1 #6915

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 17, 2024

Bumps rubocop-rspec from 2.31.0 to 3.0.1.

Release notes

Sourced from rubocop-rspec's releases.

RuboCop RSpec v3.0.1

  • Bump RuboCop requirement to +1.61. (@​ydah)

RuboCop RSpec v3.0.0

  • Remove extracted cops in Capybara, FactoryBot and Rails departments. (@​ydah)
  • Remove RuboCop::RSpec::Language::NodePattern. (@​ydah)
  • Remove RSpec/FilePath cop. (@​ydah)
  • Remove RSpec/Capybara/FeatureMethods cop. If you are using this cop, change it to use RSpec/Dialect. (@​ydah)
  • Add new RSpec/MissingExpectationTargetMethod cop. (@​krororo)
  • Fix an error for RSpec/ScatteredSetup when one of the hooks is an empty block. (@​earlopain)

These previously pending cops are now enabled by default: RSpec/BeEmpty, RSpec/BeEq, RSpec/BeNil, RSpec/ChangeByZero, RSpec/ClassCheck, RSpec/ContainExactly, RSpec/DuplicatedMetadata, RSpec/EmptyMetadata, RSpec/EmptyOutput, RSpec/Eq, RSpec/ExcessiveDocstringSpacing, RSpec/ExpectInLet, RSpec/IdenticalEqualityAssertion, RSpec/IndexedLet, RSpec/IsExpectedSpecify, RSpec/MatchArray, RSpec/MetadataStyle, RSpec/NoExpectationExample, RSpec/PendingWithoutReason, RSpec/ReceiveMessages, RSpec/RedundantAround, RSpec/RedundantPredicateMatcher, RSpec/RemoveConst, RSpec/RepeatedSubjectCall, RSpec/SkipBlockInsideExample, RSpec/SortMetadata, RSpec/SpecFilePathFormat, RSpec/SpecFilePathSuffix, RSpec/SubjectDeclaration, RSpec/UndescriptiveLiteralsDescription, and RSpec/VerifiedDoubleReference.

Read more about how to upgrade in https://docs.rubocop.org/rubocop-rspec/upgrade_to_version_3.html

RuboCop RSpec v3.0.0.pre

  • Remove extracted cops in Capybara, FactoryBot and Rails departments. (@​ydah)
  • Remove RuboCop::RSpec::Language::NodePattern. (@​ydah)
  • Remove RSpec/FilePath cop. (@​ydah)
  • Remove RSpec/Capybara/FeatureMethods cop. If you are using this cop, change it to use RSpec/Dialect. (@​ydah)
  • Enable all pending cops. (@​bquorning)
  • Add new RSpec/MissingExpectationTargetMethod cop. (@​krororo)
  • Fix an error for RSpec/ScatteredSetup when one of the hooks is an empty block. (@​earlopain)

Read more about how to upgrade in https://docs.rubocop.org/rubocop-rspec/upgrade_to_version_3.html

Changelog

Sourced from rubocop-rspec's changelog.

3.0.1 (2024-06-11)

  • Bump RuboCop requirement to +1.61. ([@​ydah])

3.0.0 (2024-06-11)

  • Remove extracted cops in Capybara, FactoryBot and Rails departments. ([@​ydah])
  • Remove RuboCop::RSpec::Language::NodePattern. ([@​ydah])
  • Remove RSpec/FilePath cop. ([@​ydah])
  • Remove RSpec/Capybara/FeatureMethods cop. If you are using this cop, change it to use RSpec/Dialect. ([@​ydah])
  • Add new RSpec/MissingExpectationTargetMethod cop. ([@​krororo])
  • Fix an error for RSpec/ScatteredSetup when one of the hooks is an empty block. ([@​earlopain])

These previously pending cops are now enabled by default: RSpec/BeEmpty, RSpec/BeEq, RSpec/BeNil, RSpec/ChangeByZero, RSpec/ClassCheck, RSpec/ContainExactly, RSpec/DuplicatedMetadata, RSpec/EmptyMetadata, RSpec/EmptyOutput, RSpec/Eq, RSpec/ExcessiveDocstringSpacing, RSpec/ExpectInLet, RSpec/IdenticalEqualityAssertion, RSpec/IndexedLet, RSpec/IsExpectedSpecify, RSpec/MatchArray, RSpec/MetadataStyle, RSpec/NoExpectationExample, RSpec/PendingWithoutReason, RSpec/ReceiveMessages, RSpec/RedundantAround, RSpec/RedundantPredicateMatcher, RSpec/RemoveConst, RSpec/RepeatedSubjectCall, RSpec/SkipBlockInsideExample, RSpec/SortMetadata, RSpec/SpecFilePathFormat, RSpec/SpecFilePathSuffix, RSpec/SubjectDeclaration, RSpec/UndescriptiveLiteralsDescription, and RSpec/VerifiedDoubleReference.

Read more about how to upgrade in https://docs.rubocop.org/rubocop-rspec/upgrade_to_version_3.html

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added dependencies ruby Pull requests that update Ruby code labels Jun 17, 2024
Bumps [rubocop-rspec](https://github.com/rubocop/rubocop-rspec) from 2.31.0 to 3.0.1.
- [Release notes](https://github.com/rubocop/rubocop-rspec/releases)
- [Changelog](https://github.com/rubocop/rubocop-rspec/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop-rspec@v2.31.0...v3.0.1)

---
updated-dependencies:
- dependency-name: rubocop-rspec
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/bundler/rubocop-rspec-3.0.1 branch from 49811af to 0e753c3 Compare June 17, 2024 08:23
Rubocop Rspec Capybara, FactoryBot and Rails specific code have been extracted from the main rubocop-rspec gem.

Adding the external extensions to keep the behaviour with the upgrade to rubocop-rspec v3.
So Dependabot will group rspec or govuk gem related upgrades into a single PR.
Copy link
Contributor Author

dependabot bot commented on behalf of github Jul 8, 2024

A newer version of rubocop-rspec exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies do not merge ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant