Add OneLogin flow for Jobseekers #7019
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This client will be used to retrieve the tokens and user info from One Login.
For better namespacing and sharing domain code across the service.
scruti
force-pushed
the
use-one-login-for-jobseekers
branch
7 times, most recently
from
3d33d38
to
7808986
Compare
|
Review app deployed to https://teaching-vacancies-review-pr-7019.test.teacherservices.cloud on AKS |
Will contain the ID from OneLogin user associated with our local user account.
We are setting up the basic end-to-end flow for a jobseeker to sign-in
into our service through GovUK One Login.
- Builds a OneLogin auth request to be redirected to from the
Jobseeker's "Sign in" button in our TV front page.
- Creates a controller to receive the response from OneLogin for our
auth requests, parse the response values and either:
A) Redirect the user to the root page with an error message if
the parsed response is an error or invalid.
B) If a successfull response is sent, it attempts to retrieve the
associated user info from OneLogin by getting a One Login token and
using it to retrieve the user info endpoint. All of it using our
OneLogin client.
- Attempts to insulate the OneLogin business/validation logic from the
controller, leaving the controller for orchestrating the service
retrieving OneLogin info, setting session values, setting the user and
redirecting.
- This work is just an anemic basic flow to do and end-to-end sign-in
through OneLogin. We need to build our full user flows from here.
scruti
force-pushed
the
use-one-login-for-jobseekers
branch
from
7808986
to
9c4681e
Compare
The value is needed to initialise Rails during testing
scruti
force-pushed
the
use-one-login-for-jobseekers
branch
from
9c4681e
to
c84faca
Compare
Add bridge page for sign in via govuk one login
…in via gov.uk one login
Redirect existing users to account found page if it's their first log…
Add account found page
…rough-one-login Sign-out Jobseekers through Govuk OneLogin
…on-logout-through-one-login Revert "Sign-out Jobseekers through Govuk OneLogin"
…r-jobseekers * origin/one_login: (34 commits) Update DfE Analytics search_performed event filter sensitive controller parameters (#7124) Cache result of hitting Google places API to try and reduce the bill (#7129) Add flexi working section to Vacancy (#7115) Send email for saved jobs 10 days before expiry (#7079) tweaking more error messages Fix Fusion ATS organisation mapping Change test to reflect error message change Change error message for invalid email addresses Update tests after copy change on professional status page Bump the npm-dependencies group with 3 updates tweaking error message tweaking profile trn error message Update jobseekers_can_manage_a_profile_spec.rb Update jobseekers_can_add_professional_status_to_their_profile_spec.rb Update jobseekers_can_add_professional_status_to_their_job_application_spec.rb Update jobseeker_helpers.rb making teacher reference number lowercase adding TRN acronym TRN content tweaks ...
As it is listed in Analytics PII, we need to also exclude it from the Rails parameter logging.
…ils-parameter-logging Exclude the one login id from Rails param logging
…m to onelogin page.
The confirmation page after creating a job alert/subscription was showing an old sign-in flow, requesting the password. Fixed it by switching it to a One Login button/link and ensuring that the users get redirected back to their job alerts dashboard (instead of the Job applications dashboard) after they sign-in from this confirmation page.
The banner displaying "You need to log in or create an account..." when an unsigned user attempts to save a vacancy or apply through a quick apply vacancy contained a link to the old in-house user registration flow. Removing the link as we now manage registrations through GovUK One Login.
…sfer page when they enter the incorrect confirmation code
…ting-subscriptions Fix login prompt after creating a subscription
scruti
changed the title
Small content tweaks to one login flow
…t when user requests to resend account transfer confirmation code
… when user requests to resend account transfer code
Onelogin resend email banner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello card URL
Changes in this PR:
TLDR:
Builds a basic end-to-end integration for the Jobseeker using GovUK One Login and sets it up for testing on the Jobseeker's
Sign-inbutton on the service front page.Detailed:
Jobseekers::GovukOneLoginnamespace in our service.OneLoginendpoints.Sign-inbutton in the service root page to test the flow-end-to-end.Missing/next steps