Add reason when extending deadline #7135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
starswan
force-pushed
the
extend-closing-date-reason
branch
2 times, most recently
from
93747f4
to
25664e5
Compare
|
Review app https://teaching-vacancies-review-pr-7135.test.teacherservices.cloud was successfully deleted |
| @@ -12,6 +12,7 @@ class Publishers::JobListing::ExtendDeadlineForm < BaseForm | |||
| validates :earliest_start_date, presence: true, date: { on_or_after: :today, on_or_before: :far_future, after: :expires_at, before: :latest_start_date }, if: -> { start_date_type == "date_range" } | |||
| validates :latest_start_date, presence: true, date: { on_or_after: :today, on_or_before: :far_future, after: :earliest_start_date }, if: -> { start_date_type == "date_range" } | |||
| validates :other_start_date_details, presence: true, if: -> { start_date_type == "other" } | |||
| validates :extension_reason, inclusion: { in: Vacancy.extension_reasons.keys } | |||
There was a problem hiding this comment.
do we need validation on other_extension_reason_details being present if extension_reason is "other_extension_reason"?
starswan
force-pushed
the
extend-closing-date-reason
branch
from
25664e5
to
91374d7
Compare
KyleMacPherson
approved these changes
Oct 7, 2024
scruti
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello card URL
https://trello.com/c/8Km7B9KX/1271-ask-for-a-reason-in-the-extend-closing-date-journey
Changes in this PR:
An an extension reason when extending a job deadline
Screenshots of UI changes:
Before
After
Next steps:
Terraform deployment required?
New development configuration to be shared?