Fix login prompt after creating a subscription #7143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scruti
force-pushed
the
fix-login-prompt-after-creating-subscriptions
branch
from
2906628
to
8d436bd
Compare
The confirmation page after creating a job alert/subscription was showing an old sign-in flow, requesting the password. Fixed it by switching it to a One Login button/link and ensuring that the users get redirected back to their job alerts dashboard (instead of the Job applications dashboard) after they sign-in from this confirmation page.
scruti
force-pushed
the
fix-login-prompt-after-creating-subscriptions
branch
from
8d436bd
to
0f70ee2
Compare
KyleMacPherson
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello card URL
Trello ticket
Changes in this PR:
The confirmation page after creating a job alert/subscription was showing an old sign-in flow, requesting the password.
Fixed it by switching it to a One Login button/link and ensuring that the users get redirected back to their job alerts dashboard (instead of the Job applications dashboard) after they sign in from this confirmation page.
Screenshots of UI changes:
Before
It was displaying a password field.
Also it was redirecting back to job applications after signing in through OneLogin.
After
For existing users
For email not matching any user
Both redirect back to this page