Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove factory bot from production #7150

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

starswan
Copy link
Contributor

@starswan starswan commented Oct 7, 2024

Trello card URL

https://trello.com/c/t421CDhu/1275-remove-factorybot-from-production-environment

Changes in this PR:

Re-create the 'sample job application' using code rather than FactoryBot in the 'create a job' flow for publishers

Screenshots of UI changes:

Before

After

Next steps:

  • Terraform deployment required?

  • New development configuration to be shared?

@starswan starswan marked this pull request as ready for review October 7, 2024 14:53
Copy link
Collaborator

@scruti scruti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Copy link

github-actions bot commented Oct 8, 2024

Review app deployed to https://teaching-vacancies-review-pr-7150.test.teacherservices.cloud on AKS

@starswan starswan force-pushed the remove-factory-bot-from-production branch from fb51a31 to 84d760f Compare October 11, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants