Fix bug in TRN section of job application #7155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KyleMacPherson
changed the title
KyleMacPherson
force-pushed
the
trn-bug
branch
from
1279140
to
b5cc416
Compare
…to lose value of has_teacher_reference_number when an error occurred
KyleMacPherson
force-pushed
the
trn-bug
branch
from
b5cc416
to
5ed7057
Compare
ddippolito
approved these changes
Oct 9, 2024
|
Review app https://teaching-vacancies-review-pr-7155.test.teacherservices.cloud was successfully deleted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello card URL
https://trello.com/c/UPdoJtgA/1285-trn-bug-fix-application-radio-response
Changes in this PR:
This PR fixes a bug in the TRN section of the job application process, which causes the value the user enters into the "Do you have a teacher reference number?" to be lost when there are errors on the page.
Note: I don't think we needed these values to be set from the jobseeker profile because we set these values in the form here
Screenshots of UI changes:
Before
After
Next steps:
Terraform deployment required?
New development configuration to be shared?