Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in the word 'Following' #199

Merged
merged 2 commits into from
Aug 9, 2024
Merged

Fix typo in the word 'Following' #199

merged 2 commits into from
Aug 9, 2024

Conversation

peteryates
Copy link
Member

No description provided.

@peteryates peteryates requested a review from a team as a code owner August 7, 2024 14:47
@saliceti
Copy link
Member

saliceti commented Aug 8, 2024

The app is not building, I think it's related to the security change in this release: https://github.com/DFE-Digital/terraform-modules/releases/tag/v0.36.0
I will investigate

Copy link

github-actions bot commented Aug 8, 2024

Review app https://technical-guidance-199.test.teacherservices.cloud was deleted

Release https://github.com/DFE-Digital/terraform-modules/releases/tag/v0.36.0
dropped default container capabilities. It included the CHOWN capability
which is required by the nginx image running as root. It caused error:
[emerg] chown("/var/cache/nginx/client_temp", 101) failed (1: Operation not permitted)
And the pod failed to start.

Switch to unprivileged docker image and using a high port to solve the
issue.
pritchyspritch added a commit that referenced this pull request Aug 9, 2024
@saliceti saliceti merged commit 62c2aa7 into master Aug 9, 2024
2 checks passed
@saliceti saliceti deleted the typo-fix branch August 9, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants