Merge pull request #711 from DHI/mypy

Update ruff and mypy to latest versions
DHI · Aug 6, 2024 · 5c512c0 · 5c512c0
2 parents 88d611b + 101b423
commit 5c512c0
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 6 deletions.
diff --git a/.github/workflows/full_test.yml b/.github/workflows/full_test.yml
@@ -22,6 +22,8 @@ jobs:
     steps:
     - uses: actions/checkout@v3
     - uses: chartboost/ruff-action@v1 # Fail fast if there are any linting errors
+      with:
+        version: 0.5.6 # consistent with pyproject.toml ?
     - name: Set up Python ${{ matrix.python-version }}
       uses: actions/setup-python@v4
       with:

diff --git a/mikeio/dataset/_dataarray.py b/mikeio/dataset/_dataarray.py
@@ -221,10 +221,10 @@ def _guess_dims(
 
         if isinstance(geometry, GeometryUndefined):
             DIMS_MAPPING = {
-                0: [],
-                1: ["x"],
-                2: ["y", "x"],
-                3: ["z", "y", "x"],
+                0: tuple(),
+                1: ("x",),
+                2: ("y", "x"),
+                3: ("z", "y", "x"),
             }
             spdims = DIMS_MAPPING[ndim_no_time]
         else:

diff --git a/pyproject.toml b/pyproject.toml
@@ -54,8 +54,8 @@ dev = ["pytest",
        "xarray",
        "netcdf4",
        "rasterio",
-       "ruff",
-       "mypy==1.6.1",
+       "ruff==0.5.6",
+       "mypy==1.11.1",
        ]
 
 test = ["pytest", "pytest-cov", "xarray","mypy==1.6.1","shapely","pyproj"]