Refonte visuelle rapide du rapport #929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bellangerq
assigned benoitdequick and AdrienMuzyczka and unassigned benoitdequick and AdrienMuzyczka
benoitdequick
approved these changes
Jan 27, 2025
hissalht
approved these changes
Jan 29, 2025
bellangerq
force-pushed
the
784-refonte-du-rapport-rapide
branch
from
cd5169b to
83d74fa
Compare
added 8 commits
February 5, 2025 16:12
bellangerq
force-pushed
the
784-refonte-du-rapport-rapide
branch
from
f85f4a0 to
221e57f
Compare
yaaax
pushed a commit
that referenced
this pull request
Feb 5, 2025
* add separator between improvements + add count on top * remove tests & references accordion, error accordion and topic number * adjust spacing between errors and small css tweaks * update report tests wording * adjust example images size * update wording on report counts * lowercase improvements count * update changelog * update tests --------- Co-authored-by: Quentin Bellanger <hello@quentin-bellanger>
yaaax
added a commit
that referenced
this pull request
Feb 6, 2025
…des-ancres-pages-dans-le-rapport' of https://github.com/DISIC/Ara into 839-bug-mauvaise-position-de-lusager-après-utilisation-des-ancres-pages-dans-le-rapport * '839-bug-mauvaise-position-de-lusager-après-utilisation-des-ancres-pages-dans-le-rapport' of https://github.com/DISIC/Ara: Update PrivacyPage.vue Refonte visuelle rapide du rapport (#929) Explicite louverture des livrables dans un nouvel onglet (#932) Corrige un petit bug visuel de la liste des audits (#930) hotfix: fix backend dockerfile and a typing issue preventing build Génère les types des payloads de l'API (#722) 859 redondance de linformation en cours (#914) add homepage in sitemap when not connected Supprime la 1ere étape du changement de mot de passe dans le compte (#926) fix typo MAJ du plan du site (#925) MAJ de la page données personnelles (#923) Supprime la page Contexte (#924) fix matomo url regex to anonymize urls Mise à jour de node en version 22.13.0 (#919) MAJ du DSFR en 1.13.0 (#915) use custom matomo vue plugin MAJ du label pour le nom de la procédure (#910) Hide dropdown menu instead of removing it from DOM (#881) Fix duplicate ids in errors and improvements tabs (#879)
yaaax
added a commit
that referenced
this pull request
Feb 6, 2025
…es dans le rapport (#945) * Fix duplicate ids in errors and improvements tabs * Update CHANGELOG * Hide dropdown menu instead of removing it from DOM (#881) * Hide dropdown menu instead of removing it from DOM Note: no more smooth transition after this change * Update CHANGELOG * MAJ du label pour le nom de la procédure (#910) * update procedure name field label * update tests * use custom matomo vue plugin * MAJ du DSFR en 1.13.0 (#915) * update dsfr package version * fix audit update notes test * update changelog * Mise à jour de node en version 22.13.0 (#919) * update node version to 22.13 * add .nvmrc * smdlfjk * fix matomo url regex to anonymize urls * Supprime la page Contexte (#924) * remove context page links and usages * remove context page component and route * update changelog --------- Co-authored-by: Quentin Bellanger <hello@quentin-bellanger> * MAJ de la page données personnelles (#923) * update privacy page content * use thead and add border for tables * Fix typo * lint stuff --------- Co-authored-by: Benoît Dequick <[email protected]> Co-authored-by: Quentin Bellanger <hello@quentin-bellanger> * MAJ du plan du site (#925) * add account dashboard, roadmpa and changelog pages to sitemap * add account, sitemap and contact pages to sitemap --------- Co-authored-by: Quentin Bellanger <hello@quentin-bellanger> * fix typo * Supprime la 1ere étape du changement de mot de passe dans le compte (#926) * skip first step * add test for already logged in passord reset * cleanup test * fix NewPasswordForm style * update changelog * add homepage in sitemap when not connected * 859 redondance de linformation en cours (#914) * replace list title with badges * remove status column in audit list * add progress bar value prop * add inline layout for progress bar * increase column gap in audits list * end align percentage * exlude transverse criteria to compute progress * fix duplication type * reduce space between progress bar and value * update changelog --------- Co-authored-by: Quentin Bellanger <hello@quentin-bellanger> * Génère les types des payloads de l'API (#722) * generate and copy api types on install * delete dist folder before generating types * disable config validation when generating types * use generated types in report * use more generated types * use generated types for account and audit listing * hide some props * use generated types in feedback form * generate prisma client before generating types * update dockerfile * clean up * add guideline * hotfix: fix backend dockerfile and a typing issue preventing build * Corrige un petit bug visuel de la liste des audits (#930) * adjust audit list grid columns * make audits list more mobile friendly * remove responsive tablet-like state --------- Co-authored-by: Quentin Bellanger <hello@quentin-bellanger> * Update CHANGELOG * feat(report): top alert message no more sticky * fix(report): scroll to anchor fixed * a hack has been added on DSFR tabs to remove overflow hidden, scroll to anchor then put back overflow hidden * the link behaviour has changed from an instant scroll to a smooth scroll (when javascript is enabled) * fix(ui): move tabs 0.1px up to hide the "one line scrolling backround" at the top * feat(AraTabs): add "icon" and "selectedTab" props * fix(report): remove tabs DSFR hack as planning to use AraTabs * feat(report): minor UI fixes * titles: in blue * results: smaller font * header: smaller bottom margin * feat(report): use AraTabs in Report * fix(AuditGenerationPage): stay on current tab on refresh * fit(ui): smooth scroll behavior (only if prefers-reduced-motion: no-preference) * Fix duplicate ids in errors and improvements tabs (#879) * Fix duplicate ids in errors and improvements tabs * Update CHANGELOG * Explicite louverture des livrables dans un nouvel onglet (#932) * modify steps * modify consult report link in audit page * update changelog * adjust download button * ignore account status * set copy link to secondary * update changelog * Refonte visuelle rapide du rapport (#929) * add separator between improvements + add count on top * remove tests & references accordion, error accordion and topic number * adjust spacing between errors and small css tweaks * update report tests wording * adjust example images size * update wording on report counts * lowercase improvements count * update changelog * update tests --------- Co-authored-by: Quentin Bellanger <hello@quentin-bellanger> * Update PrivacyPage.vue * Update CHANGELOG * fix(report): scroll to anchor fixed * a hack has been added on DSFR tabs to remove overflow hidden, scroll to anchor then put back overflow hidden * the link behaviour has changed from an instant scroll to a smooth scroll (when javascript is enabled) * fix(report): remove tabs DSFR hack as planning to use AraTabs * feat(report): minor UI fixes * titles: in blue * results: smaller font * header: smaller bottom margin * Update CHANGELOG * chore(ReportCriteria): remove useless code * fix(lint): please linter + fix non breakable spaces between « and » characters * fit(ui): remove smooth scroll behavior * chore(lint): authorize irregular whitespaces in texts For example, the non-breakable space, used in french. * fix(doc): modify CHANGELOG to better fit reality + simplify one sentence + add the 🐛 emoji * chore(ui): add comments to explain why -0.1px * chore(css): move filters CSS to a separate file --------- Co-authored-by: Quentin Bellanger <[email protected]> Co-authored-by: Adrien Boutigny <[email protected]> Co-authored-by: Quentin Bellanger <hello@quentin-bellanger> Co-authored-by: Benoît Dequick <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #784