Support triggering bar phase/clock every 4/8 bars #798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
falkTX
reviewed
Feb 6, 2025
plugins/Cardinal/src/HostTime.cpp
Outdated
| @@ -165,11 +175,25 @@ struct HostTime : TerminalModule { | |||
| outputs[kHostTimeBeat].setVoltage(hasBeat ? 10.0f : 0.0f); | |||
| outputs[kHostTimeClock].setVoltage(hasClock ? 10.0f : 0.0f); | |||
| outputs[kHostTimeBarPhase].setVoltage(barPhase * 10.0f); | |||
| outputs[kHostTimeBeatPhase].setVoltage(beatPhase * 10.0f); | |||
| outputs[kHostTimeBeatPhase].setVoltage((tick / pcontext->ticksPerBeat) * 10.0f); | |||
There was a problem hiding this comment.
this seems like a leftover... please restore the original, otherwise for hosts that dont provide time info this results in a division by zero and crash
falkTX
reviewed
Feb 6, 2025
plugins/Cardinal/src/HostTime.cpp
Outdated
| @@ -148,7 +157,8 @@ struct HostTime : TerminalModule { | |||
| ? tick / pcontext->ticksPerBeat | |||
| : 0.0f; | |||
| const float barPhase = playingWithBBT && pcontext->beatsPerBar > 0 | |||
| ? ((float) (timeInfo.beat - 1) + beatPhase) / pcontext->beatsPerBar | |||
| ? ((timeInfo.bar - 1) % barDivision) / (float) barDivision | |||
There was a problem hiding this comment.
this logic also seems wrong...
if we unfold the parenthesis we have
(
(timeInfo.bar - 1) % barDivision
) / (float) barDivision
+
(
(tick / pcontext->ticksPerBeat) / pcontext->beatsPerBar
)
this doesnt match the previous code and is likely to produce wrong results.
there is also another tick / pcontext->ticksPerBeat use that can just be beatPhase instead
There was a problem hiding this comment.
Good point, updated calculation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support triggering bar phase/clock every 4 or 8 bars in the hosttime module by adding options to the right-click context menu.
(unforunately I don't have a Linux machine to build/test this)