Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Enable parallel tests in cmake ci" #1234

Merged
merged 2 commits into from
Aug 23, 2024
Merged

Revert "Enable parallel tests in cmake ci" #1234

merged 2 commits into from
Aug 23, 2024

Conversation

sandro-elsweijer
Copy link
Collaborator

@sandro-elsweijer sandro-elsweijer commented Aug 23, 2024 •
edited
Loading

Somehow this makes the tests slower.
Local testing resulted that parallel execution of tests is orders of magnitudes slower than serial test runs.

ctest
ctest -j
ninja test
ninja test -j
ninja test -j<N>

execute each test after the previous one and are significantly faster than ctest -j<N>. Removed the $MAKEFLAGS from the test so there is no confusion that this executes the tests in parallel

Reverts #1226

@sandro-elsweijer sandro-elsweijer added shouldn't take long Can be resolved in under 30 mins CI Continuous Integration critical Should be handled ASAP priority: high Should be solved as soon as possible workload: low Would take half a day or less CMake Is about the CMake build system labels Aug 23, 2024
@sandro-elsweijer sandro-elsweijer merged commit 55e5a4e into main Aug 23, 2024
22 checks passed
@sandro-elsweijer sandro-elsweijer deleted the revert-1226-fix-enable_parallel_tests_in_cmake_ci branch August 23, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Davknapp Davknapp Davknapp approved these changes

Assignees

@Davknapp Davknapp

Labels
CI Continuous Integration CMake Is about the CMake build system critical Should be handled ASAP priority: high Should be solved as soon as possible shouldn't take long Can be resolved in under 30 mins workload: low Would take half a day or less
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sandro-elsweijer @Davknapp