Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement ghost query functions #1248

Draft
wants to merge 446 commits into
base: feature-ghost_interface
Choose a base branch
from

Conversation

sandro-elsweijer
Copy link
Collaborator

@sandro-elsweijer sandro-elsweijer commented Sep 16, 2024

Describe your changes here:
I just drafted the code and it compiles without warning. I never executed the code. Giving it to our Hydrotec advisor @holke.

Note: The typos and indentation are from the base branch of this branch and I did not correct them since the base branch is still WIP. But this branch should be (if the new code works) usable by Hydrotec.

All these boxes must be checked by the reviewers before merging the pull request:

As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.

General

  • The reviewer executed the new code features at least once and checked the results manually

  • The code follows the t8code coding guidelines

  • New source/header files are properly added to the Makefiles

  • The code is well documented

  • All function declarations, structs/classes and their members have a proper doxygen documentation

  • All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue)

Tests

  • The code is covered in an existing or new test case using Google Test

Github action

  • The code compiles without warning in debugging and release mode, with and without MPI (this should be executed automatically in a github action)

  • All tests pass (in various configurations, this should be executed automatically in a github action)

    If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):

    • Should this use case be added to the github action?
    • If not, does the specific use case compile and all tests pass (check manually)

Scripts and Wiki

  • If a new directory with source-files is added, it must be covered by the script/find_all_source_files.scp to check the indentation of these files.
  • If this PR introduces a new feature, it must be covered in an example/tutorial and a Wiki article.

License

  • The author added a BSD statement to doc/ (or already has one)

holke and others added 30 commits August 14, 2024 15:59
Co-authored-by: Sandro Elsweijer <[email protected]>
Co-authored-by: Sandro Elsweijer <[email protected]>
…terpolation

Test t8_geom_triangular_interpolation
…shell

Refactored quad/cubed sphere mesh/geometry.
…etry_checking

Add tree compatibility test for example cmesh geoms
Co-authored-by: Sandro Elsweijer <[email protected]>
Add api folder to indent all files script
only search for components of the vtk library
Johannes Markert and others added 30 commits September 27, 2024 13:29
Package source files and update actions
Add write_element_id to initializer-list
Build Fortran interface: autotools & CMake
…ty_of_geoms

Remove dimensionality of geoms
Use looser indent-script condition for all indent scripts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
draft Enhance the visibility that this is a draft. enhancement Enhances already existing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants