-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement ghost query functions #1248
Draft
sandro-elsweijer
wants to merge
446
commits into
feature-ghost_interface
Choose a base branch
from
enhancement-ghost_query_functions
base: feature-ghost_interface
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Enhancement ghost query functions #1248
sandro-elsweijer
wants to merge
446
commits into
feature-ghost_interface
from
enhancement-ghost_query_functions
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Sandro Elsweijer <[email protected]>
Co-authored-by: Sandro Elsweijer <[email protected]>
…terpolation Test t8_geom_triangular_interpolation
…shell Refactored quad/cubed sphere mesh/geometry.
Improve search callback
…etry_checking Add tree compatibility test for example cmesh geoms
Fix a warning
Fix various warnings
Co-authored-by: Sandro Elsweijer <[email protected]>
Add api folder to indent all files script
only search for components of the vtk library
Package source files and update actions
Add write_element_id to initializer-list
Build Fortran interface: autotools & CMake
Update old github links
Allow more clang-format versions
Cleanup tutorial build cmesh
…ty_of_geoms Remove dimensionality of geoms
Fix issue 1252
Use looser indent-script condition for all indent scripts
…hancement-ghost_query_functions
…s' into enhancement-ghost_query_functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes here:
I just drafted the code and it compiles without warning. I never executed the code. Giving it to our Hydrotec advisor @holke.
Note: The typos and indentation are from the base branch of this branch and I did not correct them since the base branch is still WIP. But this branch should be (if the new code works) usable by Hydrotec.
All these boxes must be checked by the reviewers before merging the pull request:
As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.
General
The reviewer executed the new code features at least once and checked the results manually
The code follows the t8code coding guidelines
New source/header files are properly added to the Makefiles
The code is well documented
All function declarations, structs/classes and their members have a proper doxygen documentation
All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue)
Tests
Github action
The code compiles without warning in debugging and release mode, with and without MPI (this should be executed automatically in a github action)
All tests pass (in various configurations, this should be executed automatically in a github action)
If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):
Scripts and Wiki
script/find_all_source_files.scp
to check the indentation of these files.License
doc/
(or already has one)