-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New settings for disable comments and social #2304
Conversation
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2304 +/- ##
==========================================
- Coverage 46.78% 46.76% -0.02%
==========================================
Files 251 251
Lines 13309 13317 +8
==========================================
+ Hits 6226 6228 +2
- Misses 7083 7089 +6 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise LGTM -- could you please rebase and squash your commits? Then we can go ahead and merge this.
…Stk/online-judge into option_for_disable_comments
I'm not used to squash and rebase, but I hope I squashed it correctly :) |
Not quite :) You want to run
|
new settings options for disabling comments and social disable-{social | comments} --> enable-{social | comments} Fixes for 2304#discussion_r1439114231
…Stk/online-judge into option_for_disable_comments
Hi, Sorry for the delay, I've been a little overwhelmed with my work, but I hope I squashed correctly now. I'm very grateful for all your help and support. Thanks again! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why was this submodule updated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Related with: #2298
Added new settings to disable social and comments sections (false by default):
Blog post example with social and comments enabled (by default):
Blog post example with social and comments disabled: