Minor changes to fix compatibility with older browsers #2355
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides 2 changes to fix compatibility with older browsers.
prefers-color-scheme
media query will fail to load any CSS when the dark/light mode code is enabled.Additionally, the W3 Specification states that the light theme should be loaded as a fallback if no preference is given.
This can trivially be resolved by removing the
prefers-color-scheme: light
media query from the light theme, to set it as the default if the browser does not handle the query.Screen.Recording.2024-10-26.at.1.51.18.PM.mov
This does not impact browsers that support the query, as
prefers-color-scheme
takes priority over the "base" stylesheet: