Optimize Org.with_template_and_user_counts (2/2)

- This is a small addition to commit 6708697.
- Rather than using all of the virtual attributes (org.has_users, org.has_contributors, org.has_plans), we 'combine' them into org.has_associations.
- Basically, has_associations == (org.has_users || org.has_contributors || org.has_plans)
- The corresponding changes are also made in app/views/paginable/orgs/_index.html.erb

app/models/org.rb

@@ -201,9 +201,9 @@ def self.default_orgs
       .group('orgs.id')
       .select("orgs.*,
               count(distinct templates.family_id) as template_count,
-              EXISTS (SELECT 1 FROM users WHERE users.org_id = orgs.id) AS has_users,
-              EXISTS (SELECT 1 FROM contributors WHERE contributors.org_id = orgs.id) AS has_contributors,
-              EXISTS (SELECT 1 FROM plans WHERE plans.org_id = orgs.id) as has_plans")
+              EXISTS (SELECT 1 FROM users WHERE users.org_id = orgs.id) OR
+              EXISTS (SELECT 1 FROM contributors WHERE contributors.org_id = orgs.id) OR
+              EXISTS (SELECT 1 FROM plans WHERE plans.org_id = orgs.id) as has_associations")
   }
 
   # EVALUATE CLASS AND INSTANCE METHODS BELOW

app/views/paginable/orgs/_index.html.erb

@@ -31,7 +31,7 @@
               </button>
               <ul class="dropdown-menu" aria-labelledby="org-<%= org.id %>-actions">
                 <li class="nav-item"><%= link_to _('Edit'), admin_edit_org_path(org), class:'dropdown-item px-3' %></li>
-                <% unless org.has_users || org.template_count > 0 || org.has_contributors || org.has_plans %>
+                <% unless org.template_count > 0 || org.has_associations? %>
                   <li class="nav-item"><%= link_to _('Remove'), super_admin_org_path(org), data: {confirm: _("You are about to delete '%{org_name}'. Are you sure?") % { org_name: org.name}}, method: :delete, class:'dropdown-item px-3' %></li>
                 <% end %>
               </ul>