Refactor @unpublished_count

Since `@published_count` is already computed, the if/else handling of `published` prior to this commit was redundant
DMPRoadmap · Jun 11, 2024 · efcecd0 · efcecd0
1 parent 70f08fa
commit efcecd0
Showing 1 changed file with 3 additions and 15 deletions.
diff --git a/app/controllers/org_admin/templates_controller.rb b/app/controllers/org_admin/templates_controller.rb
@@ -25,11 +25,7 @@ def index
       @query_params      = { sort_field: 'templates.title', sort_direction: 'asc' }
       @all_count         = templates.size
       @published_count   = published.present? ? published : 0
-      @unpublished_count = if published.present?
-                             (@all_count - published)
-                           else
-                             @all_count
-                           end
+      @unpublished_count = @all_count - @published_count
       render :index
     end
     # rubocop:enable Metrics/AbcSize
@@ -55,11 +51,7 @@ def organisational
       @query_params = { sort_field: 'templates.title', sort_direction: 'asc' }
       @all_count = templates.size
       @published_count = published.present? ? published : 0
-      @unpublished_count = if published.present?
-                             @all_count - published
-                           else
-                             @all_count
-                           end
+      @unpublished_count = @all_count - @published_count
       render :index
     end
     # rubocop:enable Metrics/AbcSize, Metrics/PerceivedComplexity
@@ -90,11 +82,7 @@ def customisable
       @query_params = { sort_field: 'templates.title', sort_direction: 'asc' }
       @all_count = funder_templates.size
       @published_count = published.present? ? published : 0
-      @unpublished_count = if published.present?
-                             (customizations_count - published)
-                           else
-                             customizations_count
-                           end
+      @unpublished_count = customizations_count - @published_count
       @not_customized_count = @all_count - customizations_count
 
       render :index