Strip Outer Spaces Of User Search String and Queried DB Fields #3433
+3
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
.squish
to the user-inputted search term,.strip
is applied as well. For example, if" x "
was typed by the user, then a query would be made for"x"
.trim()
is applied to the db values for forUser.firstname
andUser.surname
. For example, if the value for one of these fields was" x "
, then it would be trimmed to"x"
.Additional Notes:
There is still another edge-case. That is, it is possible for a
User.firstname
orUser.lastname
value to exist in the db having multiple spaces in-between non-space characters. In fact, there are two currently in the production db of DMP Assistant:It would be great to expand the concept of Fix for improving user search. #3407 to other search bars within the app, but the following issue should probably be addressed first: Address/Prevent DB Strings With Leading, Trailing, or Multiple Consecutive Spaces #3432