Fix for bugs in the Conditional Questions functionality: #3462
+1,247
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
In the case of a conditional question with answers that removed questions, any answers of removed questions was not removed. Nor were the removed answers deleted in the database.
Changes:
- Fixed the broken functionality in the method remove_answers_list in
app/helpers/conditions_helper.rb.
- Removed and destroyed the answers of the removed questions.
- Updated RSpec tests for Conditional Questions functionality.
johnpinto1
force-pushed
the
fix-for-conditional-question-removed-answers-not-being-deleted
branch
from
3bf6110
to
60474db
Compare
|
I noticed github-action suggest breaking PR. That is not sensible in this case. Separating the Rspec tests from the main code changes would break the previous RSpec tests. |
|
Hold on this PR as I have found a bug that needs fixing. So closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case of a conditional question with answers that removed questions, any answers of removed questions was not removed. Nor were the removed answers deleted in the database.
The context for why this fix was created:
An university have reported that conditional questions don't work as expected in template for one of their templates.
What happens:
Conditions for question 18 don't work.
In the past, conditions for questions Conditions for questions 8a failed too. On the day we met with them, conditions for 8a worked.
What should happen:
User says: 'When Q.18 is answered ‘None of the above applies’, Q19, 20 & 21 should go, but they are still there'. Note that the behaviour of the questions is very random. On the day met with them questions 20 and 21 had gone, only 19 was still present.