Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: finalizers #5

Merged
merged 15 commits into from
Apr 27, 2024
Merged

Feature: finalizers #5

merged 15 commits into from
Apr 27, 2024

Conversation

DNKpp
Copy link
Owner

@DNKpp DNKpp commented Apr 27, 2024

#4

Copy link

codacy-production bot commented Apr 27, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.64% (target: -1.00%) 93.48%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (90bb9d0) 512 493 96.29%
Head commit (91c0701) 1058 (+546) 1012 (+519) 95.65% (-0.64%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#5) 46 43 93.48%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

Copy link

codecov bot commented Apr 27, 2024

Codecov Report

Attention: Patch coverage is 93.47826% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 93.36%. Comparing base (90bb9d0) to head (91c0701).

Files Patch % Lines
include/mimic++/ExpectationPolicies.hpp 93.47% 3 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           development       #5      +/-   ##
===============================================
- Coverage        93.95%   93.36%   -0.60%     
===============================================
  Files                8        8              
  Lines              480      497      +17     
  Branches            64       66       +2     
===============================================
+ Hits               451      464      +13     
- Misses              19       23       +4     
  Partials            10       10              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

coveralls commented Apr 27, 2024

Pull Request Test Coverage Report for Build 8862770555

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 8 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.6%) to 95.652%

Files with Coverage Reduction New Missed Lines %
__w/mimicpp/mimicpp/include/mimic++/ExpectationPolicies.hpp 8 91.61%
Totals Coverage Status
Change from base Build 8860025243: -0.6%
Covered Lines: 506
Relevant Lines: 529

💛 - Coveralls

@DNKpp DNKpp merged commit 91c0701 into development Apr 27, 2024
45 of 48 checks passed
@DNKpp DNKpp deleted the dev/Finalizer branch April 27, 2024 21:56
@DNKpp DNKpp linked an issue Apr 27, 2024 that may be closed by this pull request
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Finalizers
2 participants