Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance state printing #99

Merged
merged 27 commits into from
Jan 27, 2025
Merged

Enhance state printing #99

merged 27 commits into from
Jan 27, 2025

Conversation

DNKpp
Copy link
Owner

@DNKpp DNKpp commented Jan 26, 2025

  • split printing/StatePrinter.hpp
  • replace explicit formatters for ValueCategory and Constness with printer specializations
  • tuple-likes are printed with parentheses.
  • ranges are printed with square brackets

Copy link

codacy-production bot commented Jan 26, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (ffb8769) 1454 1451 99.79%
Head commit (a248d7e) 1460 (+6) 1457 (+6) 99.79% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#99) 152 152 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Jan 26, 2025

Codecov Report

Attention: Patch coverage is 96.05263% with 6 lines in your changes missing coverage. Please review.

Project coverage is 96.23%. Comparing base (ffb8769) to head (a248d7e).
Report is 27 commits behind head on development.

Files with missing lines Patch % Lines
include/mimic++/matchers/StringMatchers.hpp 93.02% 0 Missing and 3 partials ⚠️
include/mimic++/printing/state/CommonTypes.hpp 94.33% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           development      #99      +/-   ##
===============================================
- Coverage        96.42%   96.23%   -0.20%     
===============================================
  Files               30       32       +2     
  Lines             1454     1460       +6     
  Branches           510      531      +21     
===============================================
+ Hits              1402     1405       +3     
+ Misses               8        6       -2     
- Partials            44       49       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

coveralls commented Jan 26, 2025

Pull Request Test Coverage Report for Build 12993893412

Details

  • 130 of 130 (100.0%) changed or added relevant lines in 6 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.001%) to 99.795%

Files with Coverage Reduction New Missed Lines %
include/mimic++/String.hpp 1 94.44%
include/mimic++/Sequence.hpp 1 98.67%
Totals Coverage Status
Change from base Build 12966501705: 0.001%
Covered Lines: 1457
Relevant Lines: 1460

💛 - Coveralls

DNKpp added 26 commits January 26, 2025 18:48
…gory to state::common_type_printer specializations
@DNKpp DNKpp merged commit a248d7e into development Jan 27, 2025
34 of 36 checks passed
@DNKpp DNKpp deleted the dev/EnhanceStatePrinter branch January 27, 2025 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants