Allow future discontinued date

[amdomanska]

Allow future discontinued date

Please don't delete any sections when completing this PR template; instead, enter N/A for checkboxes or sections which are not applicable unless otherwise stated below

See #1529

The current implementation allows future discontinued dates.

• Added changes: hide discontinued date from the ToC if in the future
• Send notifications if any journals with a discontinued date in the set future (parameterized in settings.py) are found

Currently added settings:
3. Checks for journals with a discontinued date today - settings.py DISCONTINUED_DATE_DELTA
4. background job run every day at 07:00 - settings.py HUEY_SCHEDULE["find_discontinued_soon"]

Categorisation

This PR...

• has scripts to run
• has migrations to run
• adds new infrastructure
• changes the CI pipeline
• affects the public site
• affects the editorial area
• affects the publisher area
• affects the monitoring

Basic PR Checklist

• FeatureMap annotations have been added
• Unit tests have been added/modified
• Functional tests have been added/modified
• Code has been run manually in development, and functional tests followed locally
• No deprecated methods are used
• No magic strings/numbers - all strings are in constants or messages files
• ES queries are wrapped in a Query object rather than inlined in the code
• Where possible our common library functions have been used (e.g. dates manipulated via dates)
• If needed, migration has been created and tested locally
• Have you done a recent merge up from develop
• Cleaned up commented out code, etc
• Release sheet has been created, and completed as far as is possible https://docs.google.com/spreadsheets/d/1Bqx23J1MwXzjrmAygbqlU3YHxN1Wf7zkkRv14eTVLZQ/edit#gid=239221496
• Documentation updates - if needed - have been identified and prepared for inclusion into main documentation (e.g. added and highlighted/commented as appropriate to this PR)
  • Event and Consumers documentation: https://docs.google.com/spreadsheets/d/1oIeG5vg-blm2MZCE-7YhwulUlSz6TOUeY8jAftdP9JE/edit#gid=1277065021
  • Core model documentation: https://docs.google.com/spreadsheets/d/1lun2S9vwGbyfy3WjIjgXBm05D-3wWDZ4bp8xiIYfImM/edit
  • Events and consumers documentation: https://docs.google.com/spreadsheets/d/1oIeG5vg-blm2MZCE-7YhwulUlSz6TOUeY8jAftdP9JE/edit
• There has been a recent merge up from develop (or other base branch)
• The docs for this branch have been generated and pushed to the doc site (see docs/README.md for details)

Testing

Public Site/ToC/Test Correctly Displayed Discontinued Date

Configuration changes (current settings to confirm)

Journals discontinuing in how many days (0) should be searched for?
DISCONTINUED_DATE_DELTA = 0
When and how often the background job should be run? (**everyday at 07:00 **)
HUEY_SCHEDULE["find_discontinued_soon"] = {"month": "*", "day": "*", "day_of_week": "*", "hour": "7", "minute": "0"}

[amdomanska]

Conflict resolved.

[RK206]

Small suggestion. May be it will be helpful to update Feature test to check on 'Ceased publication on ' text on TOC page

[richard-jones]

Some comments from me, and there are also other requests for changes from other reviewers

[richard-jones]

If we invent a new classification status, we need to think about how this is displayed in the notifications search UI. It will need an icon, or at least to check the edges code that shows the notifications search that it falls back to the text gracefully

[amdomanska]

Do you suggest using one of the existing ones?

NOTIFICATION_CLASSIFICATION_STATUS_CHANGE = "status_change"
NOTIFICATION_CLASSIFICATION_ASSIGN = "assign"
NOTIFICATION_CLASSIFICATION_CREATE = "create"
NOTIFICATION_CLASSIFICATION_FINISHED = "finished"

[richard-jones]

no, I think a new one makes sense, though "status" is a bit of an overloaded term. Perhaps "alert"? Then the icon can be a bell or something.

[richard-jones]

To do this, set the status in the constants like you have done, for this new "alert", then in portality/static/js/edges/notifications.edge.js add a new SVG icon in the icons dictionary, and a new description in the classifications dictionary and this should then display as appropriate

[richard-jones]

There's one remaining comment from @amdomanska about cleaning something up at merge time, otherwise this is good to go to the test/release process

[amdomanska]

There's one remaining comment from @amdomanska about cleaning something up at merge time, otherwise this is good to go to the test/release process

Done.

[Steven-Eardley]

I've fixed a missing import which prevented the background job being run

[Steven-Eardley]

@amdomanska This branch has the following genuine test failures:

=========================== short test summary info ============================
FAILED doajtest/unit/test_task_discontinued_soon.py::TestDiscontinuedSoon::test_discontinued_soon_found - TypeError: unsupported type for timedelta days component: BackgroundJob
FAILED doajtest/unit/test_task_discontinued_soon.py::TestDiscontinuedSoon::test_discontinued_soon_not_found - TypeError: unsupported type for timedelta days component: BackgroundJob
FAILED doajtest/unit/api_tests/test_apiv3_discovery.py::TestAPIDiscovery::test_03_applications - AttributeError: module 'portality.lib.dates' has no attribute 'after'
========= 3 failed, 2128 passed, 82401 warnings in 3418.57s (0:56:58) ==========

Exited with code exit status 1

[amdomanska]

Continued: #2239