Feature/3543 applicants info position and email header change

[amdomanska]

Move the applicant's email address into the Notes sticky and ensure it follows the editor down the page.
Add the ISSN into the email subject heading for all notifications defined in notifications.yml

Please don't delete any sections when completing this PR template; instead enter N/A for checkboxes or sections which are not applicable, unless otherwise stated below

See 3543

Categorisation

This PR...

• has scripts to run
• has migrations to run
• adds new infrastructure
• changes the CI pipeline
• affects the public site
• affects the editorial area
• affects the publisher area
• affects the monitoring

Basic PR Checklist

Instructions for developers:

• For each checklist item, if it is N/A to your PR check the N/A box
• For each item that you have done and confirmed for yourself, check Developer box (including if you have checked the N/A box)

Instructions for reviewers:

• For each checklist item that has been confirmed by the Developer, check the Reviewer box if you agree
• For multiple reviewers, feel free to add your own checkbox with your github username next to it if that helps with review tracking

Code Style

• No deprecated methods are used

  • N/A
  • Developer
  • Reviewer

• No magic strings/numbers - all strings are in constants or messages files

  • N/A
  • Developer
  • Reviewer

• ES queries are wrapped in a Query object rather than inlined in the code

  • N/A
  • Developer
  • Reviewer

• Where possible our common library functions have been used (e.g. dates manipulated via dates)

  • N/A
  • Developer
  • Reviewer

• Cleaned up commented out code, etc

  • N/A
  • Developer
  • Reviewer

Testing

• Unit tests have been added/modified

  • N/A
  • Developer
  • Reviewer

• Functional tests have been added/modified

  • N/A
  • Developer
  • Reviewer

• Code has been run manually in development, and functional tests followed locally

  • N/A
  • Developer
  • Reviewer

Documentation

• FeatureMap annotations have been added

  • N/A
  • Developer
  • Reviewer

• Documentation updates - if needed - have been identified and prepared for inclusion into main documentation (e.g. added and highlighted/commented as appropriate to this PR)

  • N/A
  • Developer
  • Reviewer

• Core model documentation has been added to if needed: https://docs.google.com/spreadsheets/d/1lun2S9vwGbyfy3WjIjgXBm05D-3wWDZ4bp8xiIYfImM/edit

  • N/A
  • Developer
  • Reviewer

• Events and consumers documentation has been added if needed: https://docs.google.com/spreadsheets/d/1oIeG5vg-blm2MZCE-7YhwulUlSz6TOUeY8jAftdP9JE/edit

  • N/A
  • Developer
  • Reviewer

• The docs for this branch have been generated and pushed to the doc site (see docs/README.md for details)

  • N/A
  • Developer
  • Reviewer

Release Readiness

• If needed, migration has been created and tested locally

  • N/A
  • Developer
  • Reviewer

• Release sheet has been created, and completed as far as is possible https://docs.google.com/spreadsheets/d/1Bqx23J1MwXzjrmAygbqlU3YHxN1Wf7zkkRv14eTVLZQ/edit

  • N/A
  • Developer
  • Reviewer

• There has been a recent merge up from develop (or other base branch). List the dates of the merges up from develop below
  07/07/2023

Testing

List the Functional Tests that must be run to confirm this feature

https://doaj.github.io/doaj-docs/feature/3543_applicants_info_position_and_email_header_change/testbook/index.html#notifications/notifications/short_notification_view

[Steven-Eardley]

• Tests will need to be updated, there's some tests for the email subjects during the application workflow.

• Should we have a colon in there, e.g. New application assigned to you: 1234-1234, 0000-0000 since ISSN is a required field we shouldn't need to worry about the case where they're missing.

[amdomanska]

@Steven-Eardley

Should we have a colon in there, e.g. New application assigned to you: 1234-1234, 0000-0000 since ISSN is a required field we shouldn't need to worry about the case where they're missing.

ISSN is required but not necessarily both of them (it's possible to submit an application with PISSN only)? The issns=", ".join(issn for issn in application.bibjson().issns()) adds comma if necessary ("New application assigned to your group (XXXX-XXXX)", or "New application assigned to your group (XXXX-XXXX, YYYY-YYYY)")
Unless you mean some other comma?

[Steven-Eardley]

Unless you mean some other comma?

colon : <--- :)