-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save and apply jigsaw adjustments #5419
Merged
Kelvinrr
merged 17 commits into
DOI-USGS:dev
from
chkim-usgs:jigsaw_adjustments_feature
Sep 20, 2024
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
eea8e49
Current state
chkim-usgs 24c5eda
Merge branch 'DOI-USGS:dev' into jigsaw_adjustments_feature
chkim-usgs 017d838
Save and apply bundle values
chkim-usgs d3274eb
Add test
chkim-usgs b44f75b
Update changelog
chkim-usgs 8ebeb49
Merge branch 'dev' into jigsaw_adjustments_feature
chkim-usgs 0b92ac3
Merge branch 'DOI-USGS:dev' into jigsaw_adjustments_feature
chkim-usgs bdd3b09
Merge branch 'DOI-USGS:dev' into jigsaw_adjustments_feature
chkim-usgs 470bb29
Update yaml and fix for loop issue
chkim-usgs c9d2d13
Address test failures
chkim-usgs f9897f3
Make adjustment_output and _input optional
chkim-usgs 7724d50
Merge branch 'DOI-USGS:dev' into jigsaw_adjustments_feature
chkim-usgs 6965c55
Update workflow, added new param adjustmentout_h5, updated docs
chkim-usgs 2f70374
Add orientation check
chkim-usgs 1a22f92
Update doc
chkim-usgs 1f02160
Address test failures
chkim-usgs 1a083f6
Address comments
chkim-usgs File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -27,6 +27,7 @@ dependencies: | |
- graphviz | ||
- conda-forge::gsl >=2.6, <2.7 | ||
- hdf5 | ||
- highfive | ||
- icu | ||
- inja | ||
- jama | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think if we are reading in Jigsaw results we should be able to use the ISIS CSVReader class instead of implementing the reader in Table. I could be missing something about our CSV Reader though.
Something to try when we get back to this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CSVReader was kind of a mess. I dont mind re-visiting trying it, originally, we wanted to just write out the blobs using with something like Table -> toBlob -> write(stringstream) -> write to HDF5. But that also was a mess. If we revisit I think trying the blob route would be best. She was able to get it work with a quick ghetto method than I was trying to de-tangle Blob writing with streams. Only spent a day on it, but I was getting a bunch of segfaults and stream errors for whatever reason.