Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes kaguyatc2isis invalid BandBin values #5692

Merged
merged 1 commit into from
Dec 20, 2024
Merged

fixes kaguyatc2isis invalid BandBin values #5692

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ file. Slightly modified the FunctionalTestJigsawBundleXYZ ctest accordingly. Iss
- Fixed PHOTOMET not accepting backplanes [#5281](https://github.com/DOI-USGS/ISIS3/issues/5281)
- Fixed dstripe parallel test failing by converting tests to gtests [#5613](https://github.com/DOI-USGS/ISIS3/issues/5613)
- Fixed autoseed SeedDomain = SampleLine only working for first overlap [#5673](https://github.com/DOI-USGS/ISIS3/issues/5673)
- Fixed kaguyatc2isis invalid BandBin values [#5629](https://github.com/DOI-USGS/ISIS3/issues/5629)

## [8.3.0] - 2024-09-30

Expand Down
4 changes: 2 additions & 2 deletions isis/src/kaguya/apps/kaguyatc2isis/kaguyatc2isis.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,8 +284,8 @@ namespace Isis {
// Add the BandBin group
PvlGroup bandBinGroup("BandBin");
bandBinGroup += PvlKeyword("FilterName", "BroadBand");
bandBinGroup += PvlKeyword("Center", "640nm");
bandBinGroup += PvlKeyword("Width", "420nm");
bandBinGroup += PvlKeyword("Center", "640", "nanometers");
bandBinGroup += PvlKeyword("Width", "420", "nanometers");
outcube->putGroup(bandBinGroup);
}

Expand Down
8 changes: 4 additions & 4 deletions isis/tests/FunctionalTestsKaguyatc2isis.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,8 @@ TEST(kaguyatc2isisTest, kaguyatc2isisTestDefault) {

// Bandbin Group
PvlGroup &bandbin = isisLabel->findGroup("BandBin", Pvl::Traverse);
ASSERT_EQ(bandbin["Center"][0], "640nm");
ASSERT_EQ(bandbin["Width"][0], "420nm");
ASSERT_EQ(bandbin["Center"][0], "640");
ASSERT_EQ(bandbin["Width"][0], "420");

// Kernels Group
PvlGroup &kern = isisLabel->findGroup("Kernels", Pvl::Traverse);
Expand Down Expand Up @@ -150,8 +150,8 @@ TEST(kaguyatc2isisTest, kaguyatc2isisTestSpSupport) {

// Bandbin Group
PvlGroup &bandbin = isisLabel->findGroup("BandBin", Pvl::Traverse);
ASSERT_EQ(bandbin["Center"][0], "640nm");
ASSERT_EQ(bandbin["Width"][0], "420nm");
ASSERT_EQ(bandbin["Center"][0], "640");
ASSERT_EQ(bandbin["Width"][0], "420");

// Kernels Group
PvlGroup &kern = isisLabel->findGroup("Kernels", Pvl::Traverse);
Expand Down
Loading