Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mariner10 driver and test #547

Merged
merged 5 commits into from
Jul 18, 2023
Merged

Conversation

chkim-usgs
Copy link
Contributor

Added Mariner10 driver and tests.

Some insight:

Tested with: python -m pytest tests/pytests/test_mariner_drivers.py

@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2023

Codecov Report

Merging #547 (688b00a) into main (35657fc) will decrease coverage by 0.09%.
The diff coverage is 0.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #547      +/-   ##
==========================================
- Coverage   16.99%   16.91%   -0.09%     
==========================================
  Files          53       54       +1     
  Lines        5836     5865      +29     
==========================================
  Hits          992      992              
- Misses       4844     4873      +29     
Impacted Files Coverage Δ
ale/drivers/mariner_drivers.py 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@acpaquette acpaquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks great! Nice job on figuring out the driver structure along with the mixins. Just a few things to address before we can merge it in!

ale/drivers/mariner_drivers.py Outdated Show resolved Hide resolved
ale/drivers/mariner_drivers.py Outdated Show resolved Hide resolved
ale/drivers/mariner_drivers.py Outdated Show resolved Hide resolved
acpaquette
acpaquette previously approved these changes Jun 16, 2023
Copy link
Collaborator

@acpaquette acpaquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally speaking things look good! Were you able to compare it to the original spice data? That is, did you compare an isis source spiceinit'd cube against an ale source spiceinit'd cube

@chkim-usgs
Copy link
Contributor Author

chkim-usgs commented Jun 16, 2023

@acpaquette would that be Step 7 of the Step-by-Step? I've run spiceinit after creating the new driver but I still got source=isis and no errors. I did a cmake .. and make (Building ALE) to make sure the changes took effect, but is there something else I need to do for spiceinit to pick up the changes? Note, I did create the driver in the driver_starter.ipynb notebook and had all the cells passing, outputting the isd json.

@acpaquette
Copy link
Collaborator

@chkim-usgs Could we get an addition to the change log? After that this should be good to go!

@acpaquette acpaquette merged commit 5965330 into DOI-USGS:main Jul 18, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants