Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSL Fixes/Landed Addition #558

Merged
merged 12 commits into from
Sep 7, 2023
Merged

MSL Fixes/Landed Addition #558

merged 12 commits into from
Sep 7, 2023

Conversation

acpaquette
Copy link
Collaborator

Allows MSL ISDs to be generated with zero'd positions and velocities and adjusted pointing information.

This change allows the rover images to be locally projected relative to the rover.

Works in ISIS using skymap.

@codecov-commenter
Copy link

Codecov Report

Merging #558 (20e180e) into main (99d0ff0) will decrease coverage by 0.05%.
Report is 2 commits behind head on main.
The diff coverage is 0.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main     #558      +/-   ##
==========================================
- Coverage   16.80%   16.75%   -0.05%     
==========================================
  Files          55       55              
  Lines        5904     5919      +15     
==========================================
  Hits          992      992              
- Misses       4912     4927      +15     
Files Changed Coverage Δ
ale/base/type_sensor.py 0.00% <0.00%> (ø)
ale/drivers/msl_drivers.py 0.00% <0.00%> (ø)
ale/formatters/formatter.py 0.00% <0.00%> (ø)
ale/isd_generate.py 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@AustinSanders AustinSanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all seems good to me. I'm not familiar with the inner workings of the cahvor model, but the changes seem reasonable.

@acpaquette acpaquette merged commit 193f92f into DOI-USGS:main Sep 7, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants