Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Initial ApolloPanIsisLabelIsisSpiceDriver" #617

Closed
wants to merge 1 commit into from

Conversation

AustinSanders
Copy link
Contributor

Reverts #616

Tests are failing as a result of #616 . Because there's so little info in labels after apollopaninit, the driver is not currently restrictive enough to fail for other instruments.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 14.49%. Comparing base (55ee6e4) to head (297e806).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
ale/drivers/apollo_drivers.py 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #617      +/-   ##
==========================================
+ Coverage   14.47%   14.49%   +0.01%     
==========================================
  Files          59       59              
  Lines        6858     6859       +1     
==========================================
+ Hits          993      994       +1     
  Misses       5865     5865              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Kelvinrr
Copy link
Collaborator

I think we should just get #618 working

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants