Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds dynamic reference indices to ISIS network writes #157

Merged
merged 6 commits into from
May 28, 2021

Conversation

jlaura
Copy link
Collaborator

@jlaura jlaura commented Feb 11, 2021

Reference indices can now be pulled from the data frame. PR https://github.com/USGS-Astrogeology/autocnet/pull/527 (commit is 'Fixes #524') adds the writes for dynamic reference indices into autocnet.

Copy link
Contributor

@jessemapel jessemapel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good, but needs tests.

plio/io/io_controlnetwork.py Outdated Show resolved Hide resolved
@jessemapel
Copy link
Contributor

Fixes #111

@coveralls
Copy link

coveralls commented Feb 12, 2021

Coverage Status

Changes Unknown when pulling 71b4755 on jlaura:master into ** on USGS-Astrogeology:master**.

@jlaura
Copy link
Collaborator Author

jlaura commented May 28, 2021

@jessemapel This is ready for a re-review when you get a chance. I can peel a release once this looks good and conda-forge should then update I think.

@jessemapel jessemapel merged commit 79f7dea into DOI-USGS:master May 28, 2021
Kelvinrr pushed a commit to Kelvinrr/plio that referenced this pull request May 26, 2022
* Adds dynamic reference indices to ISIS network writes

* Updates for comments

* Stub failing test

* Adds tests for referenceIndex in cnets

* Updates tests to check for warnings

* Removes travis
ladoramkershner pushed a commit to ladoramkershner/plio that referenced this pull request Jun 7, 2022
* Adds dynamic reference indices to ISIS network writes

* Updates for comments

* Stub failing test

* Adds tests for referenceIndex in cnets

* Updates tests to check for warnings

* Removes travis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants