Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add upload to build artifacts and push once together to pypi #71

Merged
merged 16 commits into from
Nov 28, 2024
Merged

ci: add upload to build artifacts and push once together to pypi #71

merged 16 commits into from
Nov 28, 2024

Conversation

dolfim-ibm
Copy link
Contributor

@dolfim-ibm dolfim-ibm commented Nov 27, 2024 •
edited
Loading

Resolves #67.
Resolves #68.

In this PR we apply the following changes

  1. Packages are first saved in the CI build artifacts, and then pushed to pypi all together.
    • these wheels will be saved also in PRs, so we can download them and try locally
  2. We use the new pypi trusted publishers option for pushing to pypi
  3. Packages are signed and published also as the GH release attachments
  4. Mac releases now support 10.13+ with a single wheel

@dolfim-ibm
ci: add upload to build artifacts and push once to pypi
d7ded66 
Signed-off-by: Michele Dolfi <[email protected]>
@dolfim-ibm
trigger ci
17fc470 
Signed-off-by: Michele Dolfi <[email protected]>
@dolfim-ibm
multiple artifacts and temp test results
0066ec1 
Signed-off-by: Michele Dolfi <[email protected]>
@dolfim-ibm
add files in ./dist
849f2f3 
Signed-off-by: Michele Dolfi <[email protected]>
@dolfim-ibm
push to testpypi with oidc permissions
717f4bf 
Signed-off-by: Michele Dolfi <[email protected]>
@dolfim-ibm
propagate token permissions
64e5e8a 
Signed-off-by: Michele Dolfi <[email protected]>
@dolfim-ibm
enable sigstore and prepare upload to gh release
c91747e 
Signed-off-by: Michele Dolfi <[email protected]>
@dolfim-ibm
trigger build
2465678 
Signed-off-by: Michele Dolfi <[email protected]>
@dolfim-ibm
allow test run
b03e8a1 
Signed-off-by: Michele Dolfi <[email protected]>
@dolfim-ibm
avoid extra release artifacts
1c95e43 
Signed-off-by: Michele Dolfi <[email protected]>
@dolfim-ibm
trigger build
8b1133d 
Signed-off-by: Michele Dolfi <[email protected]>
@dolfim-ibm
Update wheels.yml
cd7d2f6 
Signed-off-by: Michele Dolfi <[email protected]>
@dolfim-ibm dolfim-ibm mentioned this pull request Nov 28, 2024
Closed
@dolfim-ibm
use inputs to decide publish
94df76d 
Signed-off-by: Michele Dolfi <[email protected]>
@dolfim-ibm
extend token permissions
5d375ca 
Signed-off-by: Michele Dolfi <[email protected]>
@dolfim-ibm dolfim-ibm marked this pull request as ready for review November 28, 2024 09:51
PeterStaar-IBM
PeterStaar-IBM approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@PeterStaar-IBM PeterStaar-IBM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!

@dolfim-ibm dolfim-ibm merged commit 7706471 into main Nov 28, 2024
32 checks passed
@dolfim-ibm dolfim-ibm deleted the ci-use-staged-artifacts branch November 28, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeterStaar-IBM PeterStaar-IBM PeterStaar-IBM approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reduce number of mac builds Improve CI flow
2 participants
@dolfim-ibm @PeterStaar-IBM