[WIP] FFS-2326: Encapsulate Pinwheel responses into data objects #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Standard gem is not being actively used as a linter, and it's holding back Rubocop's version. Let's remove it. It also seems to be used in the `scanning.rake` file which has a bunch of code that doesn't apply to our situation (since all our scanning work is being done by GH Actions).
This will allow us to access their properties using dots, rather than having objects whose keys are a mixture of symbols and strings. This first one for the /employments endpoint is a proof of concept and I'll be following up with the rest in subsequent commits.
| <%= table.with_data_point(:employment_start_date, summary[:employment]["start_date"]) %> | ||
| <%= table.with_data_point(:employment_end_date, summary[:employment]["termination_date"]) %> | ||
| <% employment = summary[:employment] %> | ||
| <%= table.with_data_point(:employer_phone, employment.employer_phone_number.value) %> |
There was a problem hiding this comment.
Oh cool, so it handles nested stuff okay
| @http.get(build_url("#{ACCOUNTS_ENDPOINT}/#{account_id}/employment")).body | ||
| json = @http.get(build_url("#{ACCOUNTS_ENDPOINT}/#{account_id}/employment")).body | ||
|
|
||
| Employment.new(json["data"], environment: @environment) |
There was a problem hiding this comment.
Okay, I see, we're not having ARes issue requests. Makes sense why we have to do that stuff at the top.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
WIP as of 1/31.
Todo list:
Resolves FFS-2326.
Changes
Upgrade Rubocop, remove standard
Use
activeresourcegem for employment Pinwheel responseContext for reviewers
Acceptance testing
:alert: Deploy block! @ffs-eng I just merged PR [#123] and will be doing acceptance testing in demo - please don't deploy until I'm finished!)