-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix OWASP test #94
Fix OWASP test #94
Conversation
@tdooner Are we able to put Sandbox credentials for pinwheel up on github? This fails because it try's to make requests to pinwheel |
@joeyg We could, I guess, as a secret environment variable. Is OWASP going through every page in the app or something? I'm just trying to think about what the right thing to do here is architecturally - do we want to somehow stub out Pinwheel in test environments so we're not actually making 3rd party calls. Certainly the Pinwheel webhooks will not arrive properly without some legwork. Can we just have it exclude the "Start Flow Manually" link on the homepage if it's just crawling for links? |
@tdooner you can block URLs but there is a bug preventing that from working zaproxy/action-full-scan#83 |
@joeyg Hm, that sucks. Can we pass in a |
@joeyg What is your capacity going to be to work on this? Do you want to keep taking this PR on or should we take it back? |
@tdooner thanks for asking - you all should take it on if you need it done soon. My availability changes a lot from day to day. |
Closing in favor of #116 |
Ticket
Resolves FFS-1083
Changes
Context for reviewers
The OWASP test have not been running for some time.
Testing