Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidated Language Graphs V2 #266

Merged
merged 2 commits into from
Oct 15, 2024
Merged

Conversation

sachin-panayil
Copy link
Contributor

Consolidated Language Graphs

Problem

Predominant Language and Language Summary graphs showed very similar information.

Solution

Consolidated the two graphs into one using graph-toggle.

Result

User can switch between both graphs instead of having both presented at once.
chrome-capture-2024-10-15

Some important notes regarding the summary line:

  • Had a branch that got messed up so i closed it
  • This is updated and correct branch

Test Plan

Tested locally.

Signed-off-by: sachin-panayil <[email protected]>
DinneK
DinneK previously approved these changes Oct 15, 2024
Copy link
Contributor

@DinneK DinneK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@IsaacMilarky IsaacMilarky merged commit 15123cd into dev Oct 15, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants