Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Omansh part3 #3

Closed
wants to merge 10 commits into from
Closed

Omansh part3 #3

wants to merge 10 commits into from

Conversation

Omanshb
Copy link

@Omanshb Omanshb commented Oct 25, 2023

This PR contains all of the part 3 changes in the beginner project for me. I made a new dummy button on a new page /beginner, I added an endpoint to the backend, and I called that endpoint with my button.

@Omanshb Omanshb requested a review from a team as a code owner October 25, 2023 19:06
@sweep-ai
Copy link

sweep-ai bot commented Oct 25, 2023

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

@Omanshb Omanshb closed this Oct 25, 2023
@Omanshb Omanshb reopened this Oct 25, 2023
@sonarcloud
Copy link

sonarcloud bot commented Oct 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

No Coverage information No Coverage information
0.4% 0.4% Duplication

@karkir0003
Copy link
Member

@Omanshb screen recording?

@Omanshb Omanshb closed this Nov 5, 2023
@Omanshb Omanshb deleted the omansh-part3 branch November 5, 2023 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Omanshb @karkir0003 @farisdurrani @dwu359