๐ :: (#63) ๊ฐ๊ฒ ์ง๋ ๋ชฉ๋ก ๋ณด๊ธฐ API #79
Conversation
|
์ง๊ธ ์ง๋์ ์ฝ๋๋ ์ง๊ธ ํ์ฌ ์์น์์ ์ผ์ ๊ฑฐ๋ฆฌ๋ฅผ ๊ตฌํ๋ ๊ฑฐ์ผ ๋ ์์ ํด์ผํ ์ฝ๋๋ค์ด ๋๋ฌด ๋ง์ |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
ktlint
src/main/kotlin/com/cheajib/cheajibserver/domain/restaurant/service/QueryRestaurantMapListService.kt|39 col 95| Missing newline after ","
src/main/kotlin/com/cheajib/cheajibserver/domain/restaurant/service/QueryRestaurantMapListService.kt|39 col 96| Argument should be on a separate line (unless all arguments can fit a single line)
src/main/kotlin/com/cheajib/cheajibserver/domain/restaurant/service/QueryRestaurantMapListService.kt|46 col 1| Unexpected blank line(s) before "}"
src/main/kotlin/com/cheajib/cheajibserver/domain/restaurant/service/QueryRestaurantMapListService.kt|47 col 1| Needless blank line(s)
src/test/kotlin/com/cheajib/cheajibserver/QueryRestaurantMapList.kt|1 col 1| File must end with a newline (\n)
|
|
||
| // hibernate | ||
| const val HIBERNATE_SPATIAL = "org.hibernate:hibernate-spatial:6.1.3.Final" | ||
|
|
There was a problem hiding this comment.
๐ซ [ktlint] reported by reviewdog ๐ถ
Unexpected blank line(s) before "}"
| val radianAngle: Double = toRadian(bearing) | ||
| val distanceRadius: Double = distance / 6371.01 | ||
|
|
||
| val latitude: Double = Math.asin(sin(radianLatitude) * cos(distanceRadius) + |
There was a problem hiding this comment.
๐ซ [ktlint] reported by reviewdog ๐ถ
Argument should be on a separate line (unless all arguments can fit a single line)
| val radianAngle: Double = toRadian(bearing) | ||
| val distanceRadius: Double = distance / 6371.01 | ||
|
|
||
| val latitude: Double = Math.asin(sin(radianLatitude) * cos(distanceRadius) + |
There was a problem hiding this comment.
๐ซ [ktlint] reported by reviewdog ๐ถ
Missing newline after "("
| val distanceRadius: Double = distance / 6371.01 | ||
|
|
||
| val latitude: Double = Math.asin(sin(radianLatitude) * cos(distanceRadius) + | ||
| cos(radianLatitude) * sin(distanceRadius) * cos(radianAngle)) |
There was a problem hiding this comment.
๐ซ [ktlint] reported by reviewdog ๐ถ
Unexpected indentation (16) (should be 12)
| val distanceRadius: Double = distance / 6371.01 | ||
|
|
||
| val latitude: Double = Math.asin(sin(radianLatitude) * cos(distanceRadius) + | ||
| cos(radianLatitude) * sin(distanceRadius) * cos(radianAngle)) |
There was a problem hiding this comment.
๐ซ [ktlint] reported by reviewdog ๐ถ
Missing newline before ")"
| bearing = Direction.NORTHEAST.bearing | ||
| ) | ||
|
|
||
| val southWest: Location = restaurantFacade.getCoordinatesCalculate(x, y, distance = 12324.1, |
There was a problem hiding this comment.
๐ซ [ktlint] reported by reviewdog ๐ถ
Argument should be on a separate line (unless all arguments can fit a single line)
| val pointFormat = String.format("'LINESTRING(%f %f, %f %f)')", x1, y1, x2, y2) | ||
| val query = em.createNativeQuery( | ||
| "SELECT r.id, r.address, r.cordinates, r.mainImageUrl, r.imageUrl, r.isVerify" | ||
| + "FROM restaurant AS r " |
There was a problem hiding this comment.
๐ซ [ktlint] reported by reviewdog ๐ถ
Unexpected indentation (20) (should be 16)
| val pointFormat = String.format("'LINESTRING(%f %f, %f %f)')", x1, y1, x2, y2) | ||
| val query = em.createNativeQuery( | ||
| "SELECT r.id, r.address, r.cordinates, r.mainImageUrl, r.imageUrl, r.isVerify" | ||
| + "FROM restaurant AS r " |
There was a problem hiding this comment.
๐ซ [ktlint] reported by reviewdog ๐ถ
Line must not begin with "+"
| val query = em.createNativeQuery( | ||
| "SELECT r.id, r.address, r.cordinates, r.mainImageUrl, r.imageUrl, r.isVerify" | ||
| + "FROM restaurant AS r " | ||
| + "WHERE MBRContains(ST_LINESTRINGFROMTEXT(" + pointFormat + ", r.point)", Restaurant::class.java |
There was a problem hiding this comment.
๐ซ [ktlint] reported by reviewdog ๐ถ
Unexpected indentation (20) (should be 16)
| val query = em.createNativeQuery( | ||
| "SELECT r.id, r.address, r.cordinates, r.mainImageUrl, r.imageUrl, r.isVerify" | ||
| + "FROM restaurant AS r " | ||
| + "WHERE MBRContains(ST_LINESTRINGFROMTEXT(" + pointFormat + ", r.point)", Restaurant::class.java |
There was a problem hiding this comment.
๐ซ [ktlint] reported by reviewdog ๐ถ
Line must not begin with "+"
|
์ค๋ฅ ๋จ๋ ๋ถใ ใด๋ ๋ง๊ณ |
|
Kudos, SonarCloud Quality Gate passed!ย ย
|
close #63