Fix redirect URLs of bitstreams with spaces in filename

[msarmie]

References

• Fixes Redirect URLs with spaces in bitstream filename from legacy DSpace results in 404 in D7 #3871

Description

Removes encodeURIComponent in bitstream-data.service.ts#L174 because RequestParam is already encoding values

This extra encoding causes spaces to be encoded twice %20 to %2520 and URL redirect fails with 404 error.

[tdonohue]

👍 Good catch, @msarmie ! I tested this and it fixes the bug you've described.

Somewhat strangely, this bug only appears in 7.x. The line of code in 8.x or pre-9.0 does not include the encodeURIComponent() call.

So, this is definitely a bug specific to 7.x. I'm going to port your new unit test to 8.x and main to ensure that test exists on all branches (to avoid us breaking this behavior again)

[dspace-bot]

Backport failed for main, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin main
git worktree add -d .worktree/backport-3876-to-main origin/main
cd .worktree/backport-3876-to-main
git switch --create backport-3876-to-main
git cherry-pick -x 74d6dbb454cf40d5c418cc0c6cde05ea04de2103 2bd53d822abe8b811bcde9d613f68001a35ef3bf

[dspace-bot]

Backport failed for dspace-8_x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin dspace-8_x
git worktree add -d .worktree/backport-3876-to-dspace-8_x origin/dspace-8_x
cd .worktree/backport-3876-to-dspace-8_x
git switch --create backport-3876-to-dspace-8_x
git cherry-pick -x 74d6dbb454cf40d5c418cc0c6cde05ea04de2103 2bd53d822abe8b811bcde9d613f68001a35ef3bf